Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename API resource's request method #936

Merged
merged 1 commit into from Aug 5, 2020

Commits on Aug 5, 2020

  1. Rename API resource's request method

    As seen in #928, the `refresh` method doesn't work for an event class.
    This is because event has a field called `request`, and it ends up
    replacing the `request` method that it inherited from being an API
    resource, so when `refresh` tries to make a request, it fails because it
    tries to invoke it on the accessor added for the event's property.
    
    Here we give `request` a much more unique name so that it will never
    conflict with a property field again, and update all internal references
    to use the new name. We use `alias` to make the old name available for
    backwards compatibility reasons because its been around for so long that
    people are probably calling it.
    
    Fixes #928.
    brandur committed Aug 5, 2020
    Copy the full SHA
    1c37420 View commit details
    Browse the repository at this point in the history