Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for stripe-should-retry and retry-after headers #621

Merged
merged 5 commits into from Oct 5, 2019
Merged

Implement support for stripe-should-retry and retry-after headers #621

merged 5 commits into from Oct 5, 2019

Conversation

rattrayalex-stripe
Copy link
Contributor

r? @ob-stripe
cc @stripe/api-libraries @brandur-stripe

reference: stripe/stripe-node#692

ob-stripe
ob-stripe approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stripe-ci stripe-ci removed the approved label Oct 4, 2019
@rattrayalex-stripe
Copy link
Contributor Author

Added retry-after

r? @ob-stripe

@rattrayalex-stripe rattrayalex-stripe changed the title Implement support for stripe-should-retry header Implement support for stripe-should-retry and retry-after headers Oct 4, 2019
ob-stripe
ob-stripe approved these changes Oct 5, 2019
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still lgtm :)

@rattrayalex-stripe rattrayalex-stripe merged commit 8629add into master Oct 5, 2019
@rattrayalex-stripe rattrayalex-stripe deleted the ralex/should-retry branch October 5, 2019 00:48
@rattrayalex-stripe
Copy link
Contributor Author

Release in 2.37.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe approved these changes

Assignees

@rattrayalex-stripe rattrayalex-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rattrayalex-stripe @ob-stripe @stripe-ci