Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass CFLAGS and LDFLAGS when running tests #616

Merged
merged 1 commit into from Sep 14, 2019
Merged

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries

Use the LDFLAGS and CFLAGS environment variables when running tests.

Context for why this is useful:

With this PR, I can run this command on my laptop:

$ LDFLAGS="-L$(brew --prefix openssl@1.1)/lib" \
    CFLAGS="-I$(brew --prefix openssl@1.1)/include" \
    make test

and verify that tests pass with PyPy 2.

@brandur-stripe
Copy link
Contributor

Nice.

Would you mind just putting a brief comment on that line saying that it's there to enable successful crypto builds on Mac OS? Otherwise, LGTM.

ptal @ob-stripe

@ob-stripe ob-stripe merged commit 463b53a into master Sep 14, 2019
@ob-stripe ob-stripe deleted the ob-tox-pypy-fix branch September 14, 2019 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants