Use ListObject properties as default values in request methods #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this fixes the issue for me, thanks. |
brandur-stripe
approved these changes
Sep 11, 2019
|
Released as 2.36.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
I caused a regression in #610. Previously, when calling a request method on a
ListObject, theListObject's properties for headers (api_key,stripe_account,stripe_version) would be used.In #610, I added parameters for headers to request methods, but if the parameters are not passed, we would default to
Noneinstead of using theListObject's properties for the headers.This PR fixes this by using the parameter if provided, and falling back to the
ListObjectproperties if not.Fixes #611.