Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix automatic retries of failed requests #605

Merged
merged 3 commits into from Aug 20, 2019
Merged

Fix automatic retries of failed requests #605

merged 3 commits into from Aug 20, 2019
+7 −5

Commits on Aug 14, 2019

  1. fix automatic retries of failed requests

    @Changaco
    Changaco committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    92ecf98 View commit details
    Browse the repository at this point in the history

  2. fix test_retry_codes_until_exceeded 

    If the number of retries is set to 3, then the total number of requests should be 4: the initial one + the three retries.
    @Changaco
    Changaco committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    0db6767 View commit details
    Browse the repository at this point in the history

  3. improve consistency between HTTP clients 

    This commit modifies `PycurlClient` to set the `should_retry` attribute of `APIConnectionError` exceptions, like `RequestsClient` does.
    @Changaco
    Changaco committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    20df42b View commit details
    Browse the repository at this point in the history