add local pre-req script to bail early if tests will fail #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid-stripe
requested review from
a team and
prathmesh-stripe
and removed request for
a team
prathmesh-stripe
approved these changes
May 7, 2024
xavdid-stripe
added a commit
that referenced
this pull request
May 7, 2024
)" This reverts commit dc9971f.
xavdid-stripe
added a commit
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the node test suite, many tests passed but those dependent on
denoandstripe-mockonly failed after the rest of the test suite had run.For local development, it seems worthwhile to ensure those are running before running the whole suite.
Also, my understanding is
make testis only run locally, so this PR won't affect CI (or anything besides us runningmake teston our laptops). If that's not the case, let me know!