Deprecate Node methods and params based on OpenAPI spec #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Changes LGTM! For the Changelog format though, can we follow the existing Changelog entry format? Specifically we should include namespaces of resources and the full path to the resource properties. For example:
Changelog
- Mark as deprecated the
approveanddeclinemethods onIssuing.Authorization - Mark as deprecated the
persistent_tokenproperty onConfirmationToken.payment_method_preview.link,PaymentIntent.payment_method_options.link, ......
anniel-stripe
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Node SDK support for automatically marking methods and params as deprecated.
Changelog
approveanddeclinemethods onIssuing.Authorization. Instead, respond directly to the webhook request to approve an authorization.persistent_tokenproperty onConfirmationToken.PaymentMethodPreview.Link,PaymentIntent.PaymentMethodOptions.Link,PaymentIntentResource.PaymentMethodOptions.Link,PaymentMethod.Link.persistent_token.SetupIntents.PaymentMethodOptions.Card.Link.persistent_token,SetupIntentsResource.persistent_token. This is a legacy parameter that no longer has any function.