Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove API version from the path #1625

Merged
merged 4 commits into from Nov 23, 2022

Conversation

pakrym-stripe
Copy link
Contributor

@pakrym-stripe pakrym-stripe commented Nov 21, 2022

Notify

cc @stripe/api-libraries
r? @richardm-stripe

Removes the API version from the path and adjusts the package.json accordingly.

We originally put the api version in the path in anticipation of the package potentially containing type bindings for multiple API versions, but this has never materialized. We can add them back if we ever do support this.

# Conflicts:
#	types/AccountLinksResource.d.ts
#	types/AccountsResource.d.ts
#	types/ApplePayDomainsResource.d.ts
#	types/ApplicationFeesResource.d.ts
#	types/Apps/SecretsResource.d.ts
#	types/BalanceResource.d.ts
#	types/BalanceTransactionsResource.d.ts
#	types/BillingPortal/ConfigurationsResource.d.ts
#	types/BillingPortal/SessionsResource.d.ts
#	types/ChargesResource.d.ts
#	types/Checkout/SessionsResource.d.ts
#	types/CountrySpecsResource.d.ts
#	types/CouponsResource.d.ts
#	types/CreditNotesResource.d.ts
#	types/CustomerSourcesResource.d.ts
#	types/CustomersResource.d.ts
#	types/DisputesResource.d.ts
#	types/EphemeralKeysResource.d.ts
#	types/EventsResource.d.ts
#	types/ExchangeRatesResource.d.ts
#	types/ExternalAccountsResource.d.ts
#	types/FeeRefundsResource.d.ts
#	types/FileLinksResource.d.ts
#	types/FilesResource.d.ts
#	types/FinancialConnections/AccountsResource.d.ts
#	types/FinancialConnections/SessionsResource.d.ts
#	types/Identity/VerificationReportsResource.d.ts
#	types/Identity/VerificationSessionsResource.d.ts
#	types/InvoiceItemsResource.d.ts
#	types/InvoicesResource.d.ts
#	types/Issuing/AuthorizationsResource.d.ts
#	types/Issuing/CardholdersResource.d.ts
#	types/Issuing/CardsResource.d.ts
#	types/Issuing/DisputesResource.d.ts
#	types/Issuing/TransactionsResource.d.ts
#	types/MandatesResource.d.ts
#	types/PaymentIntentsResource.d.ts
#	types/PaymentLinksResource.d.ts
#	types/PaymentMethodsResource.d.ts
#	types/PayoutsResource.d.ts
#	types/PlansResource.d.ts
#	types/PricesResource.d.ts
#	types/ProductsResource.d.ts
#	types/PromotionCodesResource.d.ts
#	types/QuotesResource.d.ts
#	types/Radar/EarlyFraudWarningsResource.d.ts
#	types/Radar/ValueListItemsResource.d.ts
#	types/Radar/ValueListsResource.d.ts
#	types/RefundsResource.d.ts
#	types/Reporting/ReportRunsResource.d.ts
#	types/Reporting/ReportTypesResource.d.ts
#	types/ReviewsResource.d.ts
#	types/SetupAttemptsResource.d.ts
#	types/SetupIntentsResource.d.ts
#	types/ShippingRatesResource.d.ts
#	types/Sigma/ScheduledQueryRunsResource.d.ts
#	types/SourcesResource.d.ts
#	types/SubscriptionItemsResource.d.ts
#	types/SubscriptionSchedulesResource.d.ts
#	types/SubscriptionsResource.d.ts
#	types/TaxCodesResource.d.ts
#	types/TaxRatesResource.d.ts
#	types/Terminal/ConfigurationsResource.d.ts
#	types/Terminal/ConnectionTokensResource.d.ts
#	types/Terminal/LocationsResource.d.ts
#	types/Terminal/ReadersResource.d.ts
#	types/TestHelpers/CustomersResource.d.ts
#	types/TestHelpers/Issuing/CardsResource.d.ts
#	types/TestHelpers/RefundsResource.d.ts
#	types/TestHelpers/Terminal/ReadersResource.d.ts
#	types/TestHelpers/TestClocksResource.d.ts
#	types/TestHelpers/Treasury/InboundTransfersResource.d.ts
#	types/TestHelpers/Treasury/OutboundPaymentsResource.d.ts
#	types/TestHelpers/Treasury/OutboundTransfersResource.d.ts
#	types/TestHelpers/Treasury/ReceivedCreditsResource.d.ts
#	types/TestHelpers/Treasury/ReceivedDebitsResource.d.ts
#	types/TokensResource.d.ts
#	types/TopupsResource.d.ts
#	types/TransferReversalsResource.d.ts
#	types/TransfersResource.d.ts
#	types/Treasury/CreditReversalsResource.d.ts
#	types/Treasury/DebitReversalsResource.d.ts
#	types/Treasury/FinancialAccountsResource.d.ts
#	types/Treasury/InboundTransfersResource.d.ts
#	types/Treasury/OutboundPaymentsResource.d.ts
#	types/Treasury/OutboundTransfersResource.d.ts
#	types/Treasury/ReceivedCreditsResource.d.ts
#	types/Treasury/ReceivedDebitsResource.d.ts
#	types/Treasury/TransactionEntriesResource.d.ts
#	types/Treasury/TransactionsResource.d.ts
#	types/UsageRecordsResource.d.ts
#	types/WebhookEndpointsResource.d.ts
#	types/index.d.ts
@pakrym-stripe pakrym-stripe merged commit 547d9d3 into master Nov 23, 2022
@remi-stripe remi-stripe deleted the pakrym/Remove_API_version_from_the_path branch September 28, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants