Remove BASIC_METHODS from TS definitions (#1630)

stripe · Dec 5, 2022 · dae38f9 · dae38f9
1 parent 247c35e
commit dae38f9
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 28 deletions.
diff --git a/src/Types.d.ts b/src/Types.d.ts
@@ -193,7 +193,6 @@ type StripeResourceObject = {
   basePath: UrlInterpolator;
   path: UrlInterpolator;
   resourcePath: string;
-  includeBasic?: Array<string>;
   createResourcePathWithSymbols: (path: string | null | undefined) => string;
   createFullPath: (
     interpolator: UrlInterpolator,

diff --git a/types/lib.d.ts b/types/lib.d.ts
@@ -15,11 +15,7 @@ declare module 'stripe' {
     export class StripeResource {
       static extend<
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        T extends {[prop: string]: any} & {
-          includeBasic?: Array<
-            'create' | 'retrieve' | 'update' | 'list' | 'del'
-          >;
-        }
+        T extends {[prop: string]: any}
       >(spec: T): StripeResourceExtension<T>;
       static method<ResponseObject = object>(spec: {
         method: string;
@@ -29,27 +25,6 @@ declare module 'stripe' {
         // change/removal at any time.
         methodType?: 'list' | 'search';
       }): (...args: any[]) => Response<ResponseObject>; //eslint-disable-line @typescript-eslint/no-explicit-any
-      static BASIC_METHODS: {
-        create<T>(
-          params: CouponCreateParams,
-          options?: RequestOptions
-        ): Promise<T>;
-        retrieve<T>(
-          id: string,
-          params?: CouponRetrieveParams,
-          options?: RequestOptions
-        ): Promise<T>;
-        update<T>(
-          id: string,
-          params?: CouponUpdateParams,
-          options?: RequestOptions
-        ): Promise<T>;
-        list<T>(
-          params?: CouponListParams,
-          options?: RequestOptions
-        ): ApiListPromise<T>;
-        del<T>(id: string, options?: RequestOptions): Promise<T>;
-      };
       static MAX_BUFFERED_REQUEST_METRICS: number;
     }
     export type LatestApiVersion = '2022-11-15';

diff --git a/types/test/typescriptTest.ts b/types/test/typescriptTest.ts
@@ -170,7 +170,6 @@ stripe = new Stripe('sk_test_123', {
 })();
 
 const Foo = Stripe.StripeResource.extend({
-  includeBasic: ['retrieve'],
   foo: Stripe.StripeResource.method({
     method: 'create',
     path: 'foo',