Add prototype for enable/disable removal of spms #3577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-stripe
reviewed
May 14, 2024
Example/PaymentSheet Example/PaymentSheetUITest/CustomerSheetUITest.swift
Outdated
Show resolved
Hide resolved
.../Source/PaymentSheet/CustomerSheet/CustomerSavedPaymentMethodsCollectionViewController.swift
Outdated
Show resolved
Hide resolved
...Sheet/Source/PaymentSheet/Saved Payment Method Screen/SavedPaymentMethodCollectionView.swift
Outdated
Show resolved
Hide resolved
...heet/Source/PaymentSheet/Saved Payment Method Screen/SavedPaymentOptionsViewController.swift
Outdated
Show resolved
Hide resolved
…ITest.swift Co-authored-by: Yuki <yuki@stripe.com>
yuki-stripe
reviewed
May 15, 2024
...heet/Source/PaymentSheet/Saved Payment Method Screen/SavedPaymentOptionsViewController.swift
Outdated
Show resolved
Hide resolved
yuki-stripe
approved these changes
May 15, 2024
yuki-stripe
reviewed
May 15, 2024
| @@ -92,9 +92,9 @@ class SavedPaymentOptionsViewController: UIViewController { | |||
| return false | |||
| case 1: | |||
| // If there's exactly one PM, customer can only edit if configuration allows removal or if that single PM allows for the card brand choice to be updated. | |||
| return paymentSheetConfiguration.paymentMethodRemove && (configuration.allowsRemovalOfLastSavedPaymentMethod || viewModels.contains(where: { | |||
| return (paymentSheetConfiguration.paymentMethodRemove && configuration.allowsRemovalOfLastSavedPaymentMethod) || viewModels.contains(where: { | |||
There was a problem hiding this comment.
I feel like ideally we unit test canEditPaymentMethods instead of testing via UI test. That way we can test that various combos of paymentMethodRemove, allowsRemovalOfLastSavedPaymentMethod, and PMs produce the right value. Feel free to ticket.
There was a problem hiding this comment.
Adding a ticket. will be done as part of the CustomerSessions work stream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prototyping code under config flag to enable/disable payment method removal
Motivation
Implemented as a client side flag, which will eventually be on CustomerSession
Testing
Added ui tests