Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leaks in example app #865

Merged
merged 2 commits into from Apr 11, 2019
Merged

Fix memory leaks in example app #865

merged 2 commits into from Apr 11, 2019

Commits on Apr 11, 2019

  1. Fix memory leaks in example app 

    **Summary**
- Create `ActivitySourceCallback` to help with memory
  handling
- Refactor and clean-up classes in example app to fix
  memory leaks as identified by LeakCanary
- Call `CompositeSubscription#unsubscribe()` in
  `Activity#onDestroy()` where missing

**Motivation**
ANDROID-349

**Testing**
Ran example app
    @mshafrir-stripe
    mshafrir-stripe committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    c9150d4 View commit details
    Browse the repository at this point in the history

  2. Call super.onDestroy at end

    @mshafrir-stripe
    mshafrir-stripe committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    5238b9f View commit details
    Browse the repository at this point in the history