Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PaymentMethodCreateParams.Card creation #862

Merged
merged 1 commit into from Apr 10, 2019

Commits on Apr 10, 2019

  1. Improve PaymentMethodCreateParams.Card creation

    When creating a `PaymentMethod` with a card, the card object
    can either be created from the user's card details (e.g. card
    number, CVC, expiration), or via a Stripe token (e.g. Google
    Pay). `PaymentMethodCreateParams.Card.Builder`'s setters made
    it confusing to the developer that there were two separate
    approaches to creating a `PaymentMethodCreateParams.Card`.
    
    With this chamge, the Builder will be used when creating with
    card details, and `PaymentMethodCreateParams.Card#create` will
    be used when creating with a Stripe token.
    
    ANDROID-346
    mshafrir-stripe committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    6ef5b8b View commit details
    Browse the repository at this point in the history