-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CvcRecollection Activity #8469
Conversation
Diffuse output:
APK
|
import com.stripe.android.uicore.stripeColors | ||
import com.stripe.android.uicore.utils.stateFlowOf | ||
|
||
@Composable | ||
internal fun CvcRecollectionScreen(cardBrand: CardBrand, lastFour: String) { | ||
internal fun CvcRecollectionScreen( | ||
viewModel: CvcRecollectionViewModel = viewModel() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than pass the view model directly here, can we pass keep the parameters but add a viewActionHandler
parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then in the activity use viewModel::handleViewAction
as the parameter and observe the state in the activity as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 👍
Summary
Add host activity for CvcRecollectionScreen and util classes to launch
Logic to integrate with flow controller in next PR for ease of review
Motivation
MOBILESDK-1520
Testing
Changelog