Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CvcRecollection Activity #8469

Merged
merged 12 commits into from
May 21, 2024
Merged

Add CvcRecollection Activity #8469

merged 12 commits into from
May 21, 2024

Conversation

tjclawson-stripe
Copy link
Contributor

@tjclawson-stripe tjclawson-stripe commented May 15, 2024

Summary

Add host activity for CvcRecollectionScreen and util classes to launch
Logic to integrate with flow controller in next PR for ease of review

Motivation

MOBILESDK-1520

Testing

  • Added tests
  • Modified tests
  • Manually verified
image

Changelog

Copy link
Contributor

github-actions bot commented May 15, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │   8.1 KiB │   8.1 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   7.3 MiB │   7.3 MiB │  0 B │  18.4 MiB │  18.4 MiB │  0 B 
    asset │   1.5 MiB │   1.5 MiB │  0 B │   1.5 MiB │   1.5 MiB │  0 B 
    other │    87 KiB │    87 KiB │ +4 B │ 161.5 KiB │ 161.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.2 MiB │  12.2 MiB │ +4 B │  25.8 MiB │  25.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21688 │ 21688 │ 0 (+0 -0) 
   types │  6869 │  6869 │ 0 (+0 -0) 
 classes │  5634 │  5634 │ 0 (+0 -0) 
 methods │ 31448 │ 31448 │ 0 (+0 -0) 
  fields │ 18315 │ 18315 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3404 │ 3404 │  0
APK
   compressed    │  uncompressed   │                        
──────────┬──────┼──────────┬──────┤                        
 size     │ diff │ size     │ diff │ path                   
──────────┼──────┼──────────┼──────┼────────────────────────
 25.9 KiB │ +4 B │ 63.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
──────────┼──────┼──────────┼──────┼────────────────────────
 25.9 KiB │ +4 B │ 63.9 KiB │  0 B │ (total)

@tjclawson-stripe tjclawson-stripe marked this pull request as ready for review May 16, 2024 19:45
@tjclawson-stripe tjclawson-stripe requested review from a team as code owners May 16, 2024 19:45
import com.stripe.android.uicore.stripeColors
import com.stripe.android.uicore.utils.stateFlowOf

@Composable
internal fun CvcRecollectionScreen(cardBrand: CardBrand, lastFour: String) {
internal fun CvcRecollectionScreen(
viewModel: CvcRecollectionViewModel = viewModel()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than pass the view model directly here, can we pass keep the parameters but add a viewActionHandler parameter.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then in the activity use viewModel::handleViewAction as the parameter and observe the state in the activity as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 👍

@tjclawson-stripe tjclawson-stripe merged commit b0fec5a into master May 21, 2024
12 checks passed
@tjclawson-stripe tjclawson-stripe deleted the tyler/mobilesdk-1520 branch May 21, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants