Fix issue with single-digit expiry month not being preserved in PaymentSheet
#5422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue where card expiration dates with a single-digit month weren’t preserved correctly when closing and re-opening a
PaymentSheet
via theFlowController
.Motivation
The issue came from converting the month input to an integer and then back to a string without preserving any leading zeros. As a result,
01/23
would turn into"123"
instead of"0123"
, which was an invalid initial value for the expiration date element.We’re doing this now with
month.toString().padStart(length = 2, padChar = '0')
.Testing
Screen recordings
Before
expiry-month-bug.mp4
After
expiry-month-fixed.mp4
Changelog
[Fixed] Card expiration dates with a single-digit month are now preserved correctly when closing and re-opening the
PaymentSheet
via theFlowController
.