[Identity] Add a factory method for Compose and update the example app #5370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccen-stripe
requested review from
awush-stripe,
brnunes-stripe,
michelleb-stripe,
skyler-stripe and
jameswoo-stripe
as code owners
brnunes-stripe
suggested changes
Aug 6, 2022
identity-example/src/main/java/com/stripe/android/identity/example/network.kt
Show resolved
Hide resolved
identity/src/main/java/com/stripe/android/identity/IdentityVerificationSheet.kt
Outdated
Show resolved
Hide resolved
identity/src/main/java/com/stripe/android/identity/IdentityVerificationSheet.kt
Show resolved
Hide resolved
identity/src/main/java/com/stripe/android/identity/IdentityVerificationSheet.kt
Show resolved
Hide resolved
stripe-ci
assigned ccen-stripe and unassigned brnunes-stripe, michelleb-stripe and skyler-stripe
ccen-stripe
force-pushed
the
ccen/composeIdentity
branch
from
376c1bf
to
fa29c71
Compare
ebarrenechea-stripe
previously approved these changes
Aug 11, 2022
brnunes-stripe
previously approved these changes
Aug 11, 2022
identity-example/src/main/java/com/stripe/android/identity/example/ComposeExampleActivity.kt
Outdated
Show resolved
Hide resolved
Yes |
ccen-stripe
dismissed stale reviews from brnunes-stripe and ebarrenechea-stripe
via
37da28d
brnunes-stripe
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create
IdentityVerificationSheet.rememberVerificationSheetmethod and update the example app with a Compose activity.This change is similar to the payments change detailed in this internal doc. A minor version bump would be requested for the next release
Motivation
Support compose
Testing
Screenshots
Changelog