Create `rememberLauncher` to use Launchers in Compose #5274

brnunes-stripe · 2022-07-12T19:14:52Z

Summary

Create rememberLauncher for GooglePayLauncher, GooglePayPaymentMethodLauncher and PaymentLauncher.
Deprecate PaymentLauncher.createForCompose, which doesn't remember the PaymentLauncher instance, creating a new one at every recomposition.
Create sample Activities that use those methods on the example app.
Doc

Motivation

Support for Compose.

Testing

Added tests
Modified tests
Manually verified

github-actions · 2022-07-12T19:24:29Z

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  15.3 MiB │  15.3 MiB │ +2.5 KiB │  51.7 MiB │  51.7 MiB │ +7.4 KiB 
     arsc │   1.8 MiB │   1.8 MiB │      0 B │   1.8 MiB │   1.8 MiB │      0 B 
 manifest │     4 KiB │     4 KiB │      0 B │  18.5 KiB │  18.5 KiB │      0 B 
      res │ 871.6 KiB │ 871.6 KiB │      0 B │   1.4 MiB │   1.4 MiB │      0 B 
   native │   2.5 MiB │   2.5 MiB │      0 B │   5.9 MiB │   5.9 MiB │      0 B 
    asset │     3 MiB │     3 MiB │     -1 B │     3 MiB │     3 MiB │     -1 B 
    other │  81.7 KiB │  81.7 KiB │      0 B │ 155.5 KiB │ 155.5 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  23.5 MiB │  23.5 MiB │ +2.5 KiB │  63.9 MiB │  63.9 MiB │ +7.4 KiB 

         │          raw           │             unique              
         ├────────┬────────┬──────┼────────┬────────┬───────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff          
─────────┼────────┼────────┼──────┼────────┼────────┼───────────────
   files │      4 │      4 │    0 │        │        │               
 strings │ 250225 │ 250249 │  +24 │ 213328 │ 213350 │ +22 (+30 -8)  
   types │  44136 │  44143 │   +7 │  40513 │  40520 │  +7 (+8 -1)   
 classes │  37713 │  37720 │   +7 │  37713 │  37720 │  +7 (+8 -1)   
 methods │ 220615 │ 220645 │  +30 │ 212656 │ 212684 │ +28 (+40 -12) 
  fields │ 162620 │ 162628 │   +8 │ 161583 │ 161591 │  +8 (+13 -5)  

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  292 │  292 │  0   
 entries │ 6224 │ 6224 │  0

APK

     compressed     │    uncompressed    │                               
─────────┬──────────┼─────────┬──────────┤                               
 size    │ diff     │ size    │ diff     │ path                          
─────────┼──────────┼─────────┼──────────┼───────────────────────────────
 2.2 MiB │ +2.5 KiB │ 6.8 MiB │ +7.4 KiB │ ∆ classes3.dex                
 8.3 KiB │     -1 B │ 8.2 KiB │     -1 B │ ∆ assets/dexopt/baseline.prof 
─────────┼──────────┼─────────┼──────────┼───────────────────────────────
 2.2 MiB │ +2.5 KiB │ 6.8 MiB │ +7.4 KiB │ (total)

DEX

STRINGS:

   old    │ new    │ diff         
  ────────┼────────┼──────────────
   213328 │ 213350 │ +22 (+30 -8) 
  + ,
  ���
  ��
  ���
  ���
  
  ���
  
  ���
  
  ���
  
  ���
  �������2�0�B���¢����J%����0�2�����0�2��	��0
  2�����0H�¢���
  R�����0�X�T¢��
  ¨��
  + .
  ���
  ��
  ���
  ���
  
  ���
  
  ���
  ���
  ���
  
  ���
  �������2�0�B���¢����J*����0�2�����0�2�����0�2
  ���	����0�2��
  ��0�J*����0�2����0
  2�����0�2
  ���	����0�2��
  ��0�J)����0�2�����0�2
  ���	����0�2��
  ��0�H�¢����J)����0�2�����0�2
  ���	����0�2��
  ��0�H�¢����¨��
  + 4
  ���
  ��
  ���
  ���
  ���
  ���
  
  ���
  
  ���
  
  ���
  
  ���
  �������2�0�B���¢����J%�	��0
  2�����02��
  ��0�2�����0�H�¢����R�����0�X�T¢��
  R�����0�X�T¢��
  R�����0�X�T¢��
  R�����0�X�T¢��
  ¨��
  + ¡�
  ���
  ��
  
  ���
  
  ���
  
  ���
  
  ���
  ���
  ���
  ���
  ���
  
  ���
  
  ���
  ���
  ���
  ���
  
  ���
  ���
  ���
  
  ��
  ���
  
  ���
  ���
  ���
  
  ���
  
  ���
  
  ���
  ���
  ���
  ���
  
  ���
  ���
  ���
  ��	*�-��� <2�0�:�;<=>?@AB'��������0�������0�������0�������0	¢���
  B'��������0������0�������0�������0	¢���
  B5��������0�������0����������0�0�������0�������0�¢����B¿�����������0���������0���������0�������������0�0���������0�������0�����������0�����0�0�������������0�0�������������0�0 �����!�
  ������0�0 �������0������#��0_�����%��0&�����'��0(�����)��0*¢���+J&�5��062��7��0�2����8��092
  ���:����0�H�R���������0�0�X��¢��
  R�����0�X��¢��
  R����0�X��¢��
  R���������0�����0�0�X��¢��
  R��,��0-X��¢��
  ��.R��/��0�8�X��¢��
  ���0�1R��#��0_X��¢��
  R��2��0�X��¢��
  R��3��04X��¢��
  R���������0�0�X��¢��
  R���������0�0 X��¢��
  R�����0�X��¢��
  R�����0�X��¢��
  R��!�
  ������0�0 X��¢��
  ¨�B
  + _currentReadyCallback_delegate
  + _r8_lambda_iO--70zjc9p8JtpH7PupQdRU-jc
  + (Landroid/content/Context;Lkotlinx/coroutines/CoroutineScope;Landroidx/activity/result/ActivityResultLauncher;Lcom/stripe/android/googlepaylauncher/GooglePayPaymentMethodLauncher_Config;Lcom/stripe/android/googlepaylauncher/GooglePayPaymentMethodLauncher_ReadyCallback;)V
  + (Lcom/stripe/android/googlepaylauncher/GooglePayLauncher_Config;Lcom/stripe/android/googlepaylauncher/GooglePayLauncher_ReadyCallback;Lcom/stripe/android/googlepaylauncher/GooglePayLauncher_ResultCallback;Landroidx/compose/runtime/Composer;I)Lcom/stripe/android/googlepaylauncher/GooglePayLauncher;
  + (Lcom/stripe/android/googlepaylauncher/GooglePayPaymentMethodLauncher_Config;Lcom/stripe/android/googlepaylauncher/GooglePayPaymentMethodLauncher_ReadyCallback;Lcom/stripe/android/googlepaylauncher/GooglePayPaymentMethodLauncher_ResultCallback;Landroidx/compose/runtime/Composer;I)Lcom/stripe/android/googlepaylauncher/GooglePayPaymentMethodLauncher;
  + C(rememberLauncher)
  + C(rememberLauncher)P(1,2)
  + Lcom/stripe/android/googlepaylauncher/GooglePayLauncher_Companion_rememberLauncher_1_1;
  + Lcom/stripe/android/googlepaylauncher/GooglePayLauncher_Companion_rememberLauncher_1_2;
  + Lcom/stripe/android/googlepaylauncher/GooglePayLauncher_Companion_rememberLauncher_activityResultLauncher_1;
  + Lcom/stripe/android/googlepaylauncher/GooglePayPaymentMethodLauncher__ExternalSyntheticLambda1;
  + Lcom/stripe/android/googlepaylauncher/GooglePayPaymentMethodLauncher_6;
  + Lcom/stripe/android/googlepaylauncher/GooglePayPaymentMethodLauncher_Companion_rememberLauncher_1_1;
  + Lcom/stripe/android/googlepaylauncher/GooglePayPaymentMethodLauncher_Companion_rememberLauncher_activityResultLauncher_1;
  + Lcom/stripe/android/payments/paymentlauncher/PaymentLauncher_Companion_rememberLauncher_activityResultLauncher_1;
  + PaymentLauncher.rememberLauncher(publishableKey, stripeAccountId, callback)
  + SMAP
  GooglePayLauncher.kt
  Kotlin
  *S Kotlin
  *F
  + 1 GooglePayLauncher.kt
  com/stripe/android/googlepaylauncher/GooglePayLauncher_Companion
  + 2 CompositionLocal.kt
  androidx/compose/runtime/CompositionLocal
  + 3 Composables.kt
  androidx/compose/runtime/ComposablesKt
  + 4 Composer.kt
  androidx/compose/runtime/ComposerKt
  + 5 SnapshotState.kt
  androidx/compose/runtime/SnapshotStateKt
  *L
  1#1,341:1
  76#2:342
  76#2:343
  36#3:344
  955#4,6:345
  89#5:351
  *S KotlinDebug
  *F
  + 1 GooglePayLauncher.kt
  com/stripe/android/googlepaylauncher/GooglePayLauncher_Companion
  *L
  306#1:342
  307#1:343
  313#1:344
  313#1:345,6
  304#1:351
  *E
  
  + SMAP
  GooglePayPaymentMethodLauncher.kt
  Kotlin
  *S Kotlin
  *F
  + 1 GooglePayPaymentMethodLaunch
...✂

carlosmuvi-stripe

Good catch! bringing the same approach to Financial Connections.

example/src/main/java/com/stripe/example/activity/ComposeExampleActivity.kt

carlosmuvi-stripe · 2022-07-12T21:32:59Z

payments-core/src/main/java/com/stripe/android/googlepaylauncher/GooglePayLauncher.kt

+                resultCallback::onResult
+            )
+
+            return remember {


Should this be keyed off all of the input parameters? So that in case a different instance of any of those parameters are provided on a subsequent composition, a new instance is returned using those new values.

return remember(config, readyCallback, resultCallback) { // ... }

I think the same question would apply to the other rememberLauncher methods also. (I could be wrong – still a bit of a Compose novice!)

I'm also pretty new to Compose. You're partially right, I've updated the example to use the config as a key. For the callbacks we use rememberUpdatedState, which is also what rememberLauncherForActivityResult uses. I added you to the API review doc, ptal and let me know if you have any suggestions.

GMetaxakis

Looks good :D

brnunes-stripe added 9 commits July 1, 2022 11:12

createForCompose

4b4ce13

Merge branch 'master' into brnunes/composelauncher

63edbd2

rememberLauncher

c56d3e3

ReplaceWith

4f6169b

Merge branch 'master' into brnunes/composelauncher

8198e80

Example

da9fed4

Merge branch 'master' into brnunes/composelauncher

0d200d2

changelog

43ce045

changelog

b30b8df

carlosmuvi-stripe previously approved these changes Jul 12, 2022

View reviewed changes

stripe-ci assigned brnunes-stripe Jul 12, 2022

rememberPaymentLauncher

34fa9b3

brnunes-stripe dismissed carlosmuvi-stripe’s stale review via 34fa9b3 July 13, 2022 02:39

brnunes-stripe marked this pull request as ready for review July 13, 2022 02:39

brnunes-stripe requested review from michelleb-stripe, skyler-stripe, jameswoo-stripe, ccen-stripe and awush-stripe as code owners July 13, 2022 02:39

brnunes-stripe requested a review from carlosmuvi-stripe July 13, 2022 02:40

brnunes-stripe assigned michelleb-stripe, skyler-stripe and jameswoo-stripe and unassigned brnunes-stripe Jul 13, 2022

jameswoo-stripe previously approved these changes Jul 13, 2022

View reviewed changes

stripe-ci unassigned jameswoo-stripe Jul 13, 2022

This was referenced Jul 15, 2022

GooglePayPaymentMethodLauncher for compose #5202

Closed

[Feature] GooglePayPaymentMethodLauncher for compose #5201

Closed

GMetaxakis previously approved these changes Jul 15, 2022

View reviewed changes

brnunes-stripe added 2 commits July 15, 2022 14:23

Merge branch 'master' into brnunes/composelauncher

9796a35

rememberLauncher

e74d3aa

brnunes-stripe dismissed stale reviews from GMetaxakis and jameswoo-stripe via e74d3aa July 20, 2022 00:42

brnunes-stripe requested review from chr-stripe and jameswoo-stripe July 20, 2022 01:23

chr-stripe previously approved these changes Jul 20, 2022

View reviewed changes

Merge branch 'master' into brnunes/composelauncher

78708b0

brnunes-stripe dismissed chr-stripe’s stale review via 78708b0 July 27, 2022 00:12

brnunes-stripe requested a review from chr-stripe July 27, 2022 20:27

brnunes-stripe assigned jameswoo-stripe Jul 27, 2022

michelleb-stripe approved these changes Jul 27, 2022

View reviewed changes

stripe-ci unassigned michelleb-stripe Jul 27, 2022

chr-stripe approved these changes Jul 27, 2022

View reviewed changes

skyler-stripe approved these changes Jul 27, 2022

View reviewed changes

stripe-ci unassigned skyler-stripe Jul 27, 2022

brnunes-stripe merged commit 2c4e0e8 into master Jul 27, 2022

brnunes-stripe deleted the brnunes/composelauncher branch July 27, 2022 21:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create `rememberLauncher` to use Launchers in Compose #5274

Create `rememberLauncher` to use Launchers in Compose #5274

brnunes-stripe commented Jul 12, 2022 •

edited

github-actions bot commented Jul 12, 2022 •

edited

carlosmuvi-stripe left a comment

carlosmuvi-stripe Jul 12, 2022

chr-stripe Jul 15, 2022 •

edited

brnunes-stripe Jul 20, 2022

GMetaxakis left a comment

Create rememberLauncher to use Launchers in Compose #5274

Create rememberLauncher to use Launchers in Compose #5274

Conversation

brnunes-stripe commented Jul 12, 2022 • edited

Summary

Motivation

Testing

github-actions bot commented Jul 12, 2022 • edited

carlosmuvi-stripe left a comment

Choose a reason for hiding this comment

carlosmuvi-stripe Jul 12, 2022

Choose a reason for hiding this comment

chr-stripe Jul 15, 2022 • edited

Choose a reason for hiding this comment

brnunes-stripe Jul 20, 2022

Choose a reason for hiding this comment

GMetaxakis left a comment

Choose a reason for hiding this comment

Create `rememberLauncher` to use Launchers in Compose #5274

Create `rememberLauncher` to use Launchers in Compose #5274

brnunes-stripe commented Jul 12, 2022 •

edited

github-actions bot commented Jul 12, 2022 •

edited

chr-stripe Jul 15, 2022 •

edited