New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist GooglePayLauncherViewModel state #5226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brnunes-stripe
requested review from
michelleb-stripe,
skyler-stripe,
jameswoo-stripe and
ccen-stripe
as code owners
June 28, 2022 21:01
Diffuse output:
APK
DEX
|
jameswoo-stripe
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Persist
GooglePayLauncherViewModel
state across process death.GooglePayLauncherViewModel.hasLaunched
was kept in memory, so if the ViewModel was destroyed and recreated, it would launch Google Pay again. This is already fixed inGooglePayPaymentMethodLauncherViewModel
.Also fix the example
GooglePayLauncherIntegrationActivity
which would request a new Payment Intent when the activity is recreated.Motivation
Fix #5193
Testing
Hard to test killing and restoring process, probably a good candidate for the instrumentation tests.