Restore selected payment method when user returns to Link #5148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brnunes-stripe
requested review from
michelleb-stripe,
skyler-stripe and
jameswoo-stripe
as code owners
|
Diffuse output: APKDEX |
# Conflicts: # link/src/main/java/com/stripe/android/link/ui/paymentmethod/PaymentMethodViewModel.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
LinkPaymentLauncher.setuptakes as argument the previously selectedLinkPaymentDetails, and properly shows it as selected when the user returns to Link in the custom flow.PaymentMethodscreen receive a parameter determining if it should show the previously selected payment method, fetched from the arguments.LinkPaymentDetails, representing saved and new payment methods. A new payment method must hold the data entered by the user so the form can be pre-filled with those values when the user returns.PaymentMethodCreateParamsinto a Map that can be used to pre-fill the forms. Move intopayments-ui-coreso that Link also can use it.Motivation
Load previously selected payment method when user returns to Link in the custom flow.
https://jira.corp.stripe.com/browse/MOBILESDK-863
Testing