New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to re-fetch intent for 3ds2 #5138
Conversation
2bc6166
to
9bbf097
Compare
Diffuse output:
APK
DEX
|
e3c5a34
to
8efbbee
Compare
} | ||
|
||
@Test | ||
fun `3ds2 canceled with processing intent should succeed`() = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoke on slack.
The name here indicates that if we end up in the processing state we should emit a success but ... the test is actually checking to see if a processing intent eventually becomes a succeeded, then we can emit success. Maybe we could name this better or add a comment if the name ends being too long. Ditto for the others.
I can look at the test and PR and figure out what's going on, but maybe renaming would make it more explicit. Up to you.
I'm trying this out and confused by the behavior in the normal approval case: I get into |
It does look like the refresh behavior is working, at least. The initial state of the PI is |
8efbbee
to
5fc812c
Compare
Summary
This patch:
Motivation
Fixes https://jira.corp.stripe.com/browse/RUN_MOBILESDK-986
Analogue to https://github.com/stripe-ios/stripe-ios/pull/1096
Testing
Manual testing:
Changelog