[Financial Connections] Compose support. #5117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ial-connections-module # Conflicts: # financial-connections/build.gradle
carlosmuvi-stripe
requested review from
brnunes-stripe,
michelleb-stripe,
skyler-stripe,
ccen-stripe,
awush-stripe and
jameswoo-stripe
as code owners
|
Diffuse output: APKMANIFESTDEXARSC |
Comment on lines
86
to
95
| @Composable | ||
| fun createComposable( | ||
| callback: (FinancialConnectionsSheetResult) -> Unit | ||
| ): FinancialConnectionsSheet = FinancialConnectionsSheet( | ||
| FinancialConnectionsSheetForDataLauncher( | ||
| rememberLauncherForActivityResult( | ||
| FinancialConnectionsSheetForDataContract() | ||
| ) { callback(it) } | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Alternatively we could use the same naming we do in the Payments SDK. However, this is not the Compose naming convention when using the remember API.
jameswoo-stripe
previously approved these changes
Jun 6, 2022
ccen-stripe
previously approved these changes
Jun 6, 2022
|
Should we also migrate |
carlosmuvi-stripe
dismissed stale reviews from ccen-stripe and jameswoo-stripe
via
bfe91c7
carlosmuvi-stripe
added
the
financial-connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rememberFinancialConnectionsSheetandrememberFinancialConnectionsSheetForToken@composable functions.Why not on a different module?
SDK binary size would be a concern that could be solved by having a
financial-connections-composekind of module for integrators using Compose. However, we're planning on using Compose in the SDK as well so we're not seeing added value on an extra module.Motivation
Support Financial Connections in Jetpack Compose.
Screenshots
flow.mp4
Changelog