Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct cvc icon in card form view #5094

Merged
merged 2 commits into from May 31, 2022
Merged

Use correct cvc icon in card form view #5094

merged 2 commits into from May 31, 2022

Conversation

skyler-stripe
Copy link
Contributor

Summary

  • Uses the correct CVC resource, from 'payments-model`, on our CardFormView
  • Deleted unused CVC icons from payments-core

Motivation

  • The icon is now correct.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
cvcBefore cvcAfter

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2022

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  13.9 MiB │  13.9 MiB │    -13 B │  46.4 MiB │  46.4 MiB │   -144 B 
     arsc │   1.7 MiB │   1.7 MiB │   -176 B │   1.7 MiB │   1.7 MiB │   -176 B 
 manifest │   3.5 KiB │   3.5 KiB │      0 B │  15.7 KiB │  15.7 KiB │      0 B 
      res │ 825.4 KiB │ 822.7 KiB │ -2.7 KiB │   1.3 MiB │   1.3 MiB │ -5.6 KiB 
   native │   5.4 MiB │   5.4 MiB │      0 B │  13.4 MiB │  13.4 MiB │      0 B 
    asset │     3 MiB │     3 MiB │     +1 B │     3 MiB │     3 MiB │     +1 B 
    other │  79.9 KiB │  79.9 KiB │      0 B │ 154.8 KiB │ 154.8 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  24.8 MiB │  24.8 MiB │ -2.9 KiB │    66 MiB │    66 MiB │ -5.9 KiB 

         │          raw           │            unique            
         ├────────┬────────┬──────┼────────┬────────┬────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff       
─────────┼────────┼────────┼──────┼────────┼────────┼────────────
   files │      4 │      4 │    0 │        │        │            
 strings │ 225999 │ 225997 │   -2 │ 196713 │ 196712 │ -1 (+0 -1) 
   types │  39417 │  39417 │    0 │  35971 │  35971 │  0 (+0 -0) 
 classes │  33332 │  33332 │    0 │  33332 │  33332 │  0 (+0 -0) 
 methods │ 202870 │ 202870 │    0 │ 194713 │ 194713 │  0 (+0 -0) 
  fields │ 150244 │ 150239 │   -5 │ 149240 │ 149235 │ -5 (+0 -5) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  293 │  293 │  0         
 entries │ 5801 │ 5800 │ -1 (+0 -1)
APK
     compressed      │    uncompressed     │                               
──────────┬──────────┼──────────┬──────────┤                               
 size     │ diff     │ size     │ diff     │ path                          
──────────┼──────────┼──────────┼──────────┼───────────────────────────────
          │ -1.5 KiB │          │ -3.2 KiB │ - res/I4.xml                  
          │ -1.2 KiB │          │ -2.4 KiB │ - res/w7.xml                  
  1.7 MiB │   -176 B │  1.7 MiB │   -176 B │ ∆ resources.arsc              
  3.3 MiB │    -38 B │  8.9 MiB │    -64 B │ ∆ classes2.dex                
  3.8 MiB │    +28 B │ 11.4 MiB │    -80 B │ ∆ classes3.dex                
  6.5 MiB │     -3 B │ 25.3 MiB │      0 B │ ∆ classes.dex                 
  7.3 KiB │     +1 B │  7.2 KiB │     +1 B │ ∆ assets/dexopt/baseline.prof 
  1.1 KiB │     +1 B │  2.9 KiB │      0 B │ ∆ res/5d.xml                  
  1.5 KiB │     -1 B │  4.9 KiB │      0 B │ ∆ res/Gh.xml                  
  1.3 KiB │     -1 B │  3.9 KiB │      0 B │ ∆ res/_n.xml                  
──────────┼──────────┼──────────┼──────────┼───────────────────────────────
 15.3 MiB │ -2.9 KiB │ 47.3 MiB │ -5.9 KiB │ (total)
DEX
STRINGS:

   old    │ new    │ diff       
  ────────┼────────┼────────────
   196713 │ 196712 │ -1 (+0 -1) 
  - stripe_ic_paymentsheet_cvc
  

FIELDS:

   old    │ new    │ diff       
  ────────┼────────┼────────────
   149240 │ 149235 │ -5 (+0 -5) 
  - com.stripe.android.R_drawable stripe_ic_paymentsheet_cvc: int
  - com.stripe.android.link.R_drawable stripe_ic_paymentsheet_cvc: int
  - com.stripe.android.paymentsheet.R_drawable stripe_ic_paymentsheet_cvc: int
  - com.stripe.android.paymentsheet.example.R_drawable stripe_ic_paymentsheet_cvc: int
  - com.stripe.android.ui.core.R_drawable stripe_ic_paymentsheet_cvc: int
ARSC
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   5801 │ 5800 │ -1 (+0 -1) 
  - drawable/stripe_ic_paymentsheet_cvc

@skyler-stripe skyler-stripe merged commit 7f65c2f into master May 31, 2022
@skyler-stripe skyler-stripe deleted the fixCardFormCvc branch May 31, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants