Fix missing theming for add lpm button and notes text #5068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyler-stripe
requested review from
brnunes-stripe,
michelleb-stripe,
jameswoo-stripe,
ccen-stripe and
awush-stripe
as code owners
skyler-stripe
commented
May 25, 2022
| @@ -593,131 +599,129 @@ internal fun PaymentOptionUi( | |||
| ) { | |||
| // An attempt was made to not use constraint layout here but it was unsuccessful in | |||
| // precisely positioning the check and delete icons to match the mocks. | |||
| PaymentsTheme { | |||
| ConstraintLayout( | |||
| ConstraintLayout( | |||
There was a problem hiding this comment.
This looks like I changed way more than I did. I just removed the PaymentsTheme being set.
jameswoo-stripe
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
PaymentsTheme, this is best practice anways so that we can mutate the theme during testing. This was a miss while I was refactoring. I'm investigating why the screenshot tests didn't fail on this, I think they could be stricter.Testing
Screenshots
Changelog