Improve PaymentMethodCreateParams.Card creation #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a `PaymentMethod` with a card, the card object can either be created from the user's card details (e.g. card number, CVC, expiration), or via a Stripe token (e.g. Google Pay). `PaymentMethodCreateParams.Card.Builder`'s setters made it confusing to the developer that there were two separate approaches to creating a `PaymentMethodCreateParams.Card`. With this chamge, the Builder will be used when creating with card details, and `PaymentMethodCreateParams.Card#create` will be used when creating with a Stripe token. ANDROID-346
jemerick-stripe
approved these changes
Apr 10, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When creating a
PaymentMethodwith a card, the card objectcan either be created from the user's card details (e.g. card
number, CVC, expiration), or via a Stripe token (e.g. Google
Pay).
PaymentMethodCreateParams.Card.Builder's setters madeit confusing to the developer that there were two separate
approaches to creating a
PaymentMethodCreateParams.Card.With this change, the Builder will be used when creating with
card details, and
PaymentMethodCreateParams.Card#createwillbe used when creating with a Stripe token.
Motivation
ANDROID-346
Testing
Updated tests