Revert PR #867 #894
Merged
Revert PR #867 #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had forgotten, or possibly never knew, so don't worry about it! |
|
Just to let you know, only as a smoke-test, I've tried updating to this PR's revision in our project (see below) and everything wokrs now just as it was with 1.3.0 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #867 . This is a hotfix.
@glesica , excuse me, didn't realise the intention was to maintain
*testing.Tcompatibility with this interface.I recommend we release this as a hotfix (v1.5.1) as soon as it has been thoroughly reviewed and merged.