Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary objects as the sole element in msgAndArgs #699

Merged

Conversation

viswajithiii
Copy link
Contributor

Currently, if msgAndArgs contains exactly one element, it's expected to be a string -- and if it's not, the framework panics, which makes it hard to debug the actual test failure. So, if the object passed is not a string, then print it using the %+v modifier.

This will make life slightly more convenient for clients. It doesn't break existing programs in any way.

@viswajithiii
Copy link
Contributor Author

@georgelesica-wf Can you review this?

(Test failure is only on tip, and appears to be unrelated.)

Copy link

@georgelesica-wf georgelesica-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Sorry it took a couple days for me to get to it. I'm going to have one additional person review it just in case, but I don't anticipate any issues.

@viswajithiii
Copy link
Contributor Author

Thanks @georgelesica-wf!

@georgelesica-wf georgelesica-wf merged commit 5b93e2d into stretchr:master Dec 12, 2018
@viswajithiii
Copy link
Contributor Author

Thanks for merging! Do you know when you'll cut a release next?

@georgelesica-wf
Copy link

I need to figure out the process the project follows for that, but I'll try to do it next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants