Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go1.11 to CI #659

Merged
merged 6 commits into from Oct 2, 2018
Merged

Add Go1.11 to CI #659

merged 6 commits into from Oct 2, 2018

Conversation

leighmcculloch
Copy link
Contributor

What

Add Go1.11 to CI.

Why

Go1.11 has been released and should be tested against and supported.

@hanzei
Copy link
Contributor

hanzei commented Sep 16, 2018

I propose to drop support for go 1.8. One and a half year of go is fine.

@leighmcculloch
Copy link
Contributor Author

@ernesto-jimenez Should I remove Go1.8 too?

@leighmcculloch
Copy link
Contributor Author

I updated the PR removing 1.8.

@devdinu
Copy link
Contributor

devdinu commented Sep 17, 2018

It should be backward compatible, as long as we don't face any issues we could keep the 1.8

@leighmcculloch
Copy link
Contributor Author

@hanzei @devdinu I've reverted the changes regarding Go1.8. The PR is limited to only adding Go1.11 again now.

README.md Outdated Show resolved Hide resolved
Copy link

@georgelesica-wf georgelesica-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@leighmcculloch
Copy link
Contributor Author

👋 What else needs to happen to get this merged? PR #607 is dependent on this.

@georgelesica-wf
Copy link

@leighmcculloch we're waiting for someone to grant me merge permissions, sorry so slow!

@leighmcculloch
Copy link
Contributor Author

@ernesto-jimenez @matryer Do either of you have merge access, or able to provide @georgelesica-wf with merge access? ❤️

@georgelesica-wf georgelesica-wf merged commit 14d66a7 into stretchr:master Oct 2, 2018
@leighmcculloch
Copy link
Contributor Author

Thanks for merging @georgelesica-wf !

@leighmcculloch leighmcculloch deleted the go1dot11 branch October 3, 2018 02:45
@leighmcculloch
Copy link
Contributor Author

Now that this has been merged I've updated #607 (Add go.mod) based on this.

georgelesica-wf pushed a commit that referenced this pull request Dec 28, 2018
What
===
Add `go.mod` and `go.sum`, using `Go 1.11`.

Why
===
Now that golang/go#24301 has been accepted, lets start using go.mod files
alongside Godep, and keep the two in sync.

Notes
===
There are no changes required to testify to support go.mod. The files were
generated by running `go build` and `go mod tidy.

Merging
===
This PR is intended to be merged after #659 which adds Go1.11 to the list of
supported builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants