Add Go1.11 to CI #659
Merged
Add Go1.11 to CI #659
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I propose to drop support for go 1.8. One and a half year of go is fine. |
|
@ernesto-jimenez Should I remove Go1.8 too? |
|
I updated the PR removing 1.8. |
|
It should be backward compatible, as long as we don't face any issues we could keep the 1.8 |
Closed
johnlockwood-wf
approved these changes
Sep 18, 2018
|
👋 What else needs to happen to get this merged? PR #607 is dependent on this. |
|
@leighmcculloch we're waiting for someone to grant me merge permissions, sorry so slow! |
|
@ernesto-jimenez @matryer Do either of you have merge access, or able to provide @georgelesica-wf with merge access? ❤️ |
|
Thanks for merging @georgelesica-wf ! |
|
Now that this has been merged I've updated #607 (Add go.mod) based on this. |
georgelesica-wf
pushed a commit
that referenced
this pull request
Dec 28, 2018
What === Add `go.mod` and `go.sum`, using `Go 1.11`. Why === Now that golang/go#24301 has been accepted, lets start using go.mod files alongside Godep, and keep the two in sync. Notes === There are no changes required to testify to support go.mod. The files were generated by running `go build` and `go mod tidy. Merging === This PR is intended to be merged after #659 which adds Go1.11 to the list of supported builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add Go1.11 to CI.
Why
Go1.11 has been released and should be tested against and supported.