Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a panic when comparing types where the underlying type is string #622

Closed
wants to merge 1 commit into from
Closed

Fix a panic when comparing types where the underlying type is string #622

wants to merge 1 commit into from

Commits on Jun 25, 2018

  1. Fix a panic when comparing types where the underlying type is string 

    The code was checking if the type's _kind_ was string and then attempting to
do a type assertion of `var.(string)`. However, this assertion only works if
the type actually _is_ a string. If it's some other type (like `type foo
string`) then this ends up giving us a runtime panic.
    @autarch
    autarch committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    166049b View commit details
    Browse the repository at this point in the history