Display arguments Diff during panic #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| res := m.GetTime(1) | ||
| require.Equal(t, "SomeTime", res) | ||
| m.AssertExpectations(t) | ||
| } |
There was a problem hiding this comment.
Should we add a test without MatchedBy to make sure in the future we avoid messing up the messages in those cases?
There was a problem hiding this comment.
i've updated the commit with a test for that case.
devdinu
force-pushed
the
master
branch
2 times, most recently
from
584ee2b
to
7538ed3
Compare
|
@devdinu can you fixup the commit into a single one? Thanks! |
…sest function call. closes stretchr#556
ernesto-jimenez
approved these changes
Mar 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when expected method call wasn't found, but there's a closest method display the diff during panic.
especially this helps for argumentMatcher. closes #556