README: link out to the excellent testifylint #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc: @Antonboom for review |
dolmen
previously approved these changes
Mar 7, 2024
dolmen
changed the title
|
@brackendawson It would be good to also link to testifylint from the packages documentations for more visibility. |
I checked the render locally.
Antonboom
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Thank you, guys!
Appreciated.
For readers this PR, welcome to contribution 🙏
https://github.com/Antonboom/testifylint/blob/master/CONTRIBUTING.md#open-for-contribution
dolmen
requested changes
Mar 19, 2024
Co-authored-by: Olivier Mengué <dolmen@cpan.org>
dolmen
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a call to action to the README to use testifylint.
Changes
Motivation
Testify has many pitfalls due to the quality of some parts of the API, a lot of these cannot be fixed in testify without breaking the Go modules compatibility promise. testifylint can warn users when they fall in these pits.