Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert: fix missing *http.Request.RequestURI #1495

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hidu
Copy link
Contributor

@hidu hidu commented Oct 29, 2023

RequestURI is the unmodified request-target of the Request-Line (RFC 7230, Section 3.1.1) as sent by the client to a server.

https://pkg.go.dev/net/http@go1.21.3#Request

Summary

Changes

Motivation

func useURI(w http.ResponseWriter, r *http.Request) {
	_, _ = fmt.Fprintf(w, "URI: %s\n", r.RequestURI)  // expect RequestURI not empty
}

Related issues

@dolmen dolmen added the pkg-assert Change related to package testify/assert label Oct 30, 2023
@hidu hidu force-pushed the master branch 2 times, most recently from 22cbfc6 to 679891a Compare November 1, 2023 09:36
@hidu hidu force-pushed the master branch 2 times, most recently from 49cb96b to 9e4c352 Compare November 28, 2023 01:55
@dolmen dolmen added the bug label Mar 6, 2024
@hidu hidu force-pushed the master branch 3 times, most recently from d8e5b33 to 4f66a04 Compare March 12, 2024 06:31
RequestURI is the unmodified request-target of the
Request-Line (RFC 7230, Section 3.1.1) as sent by the client to a server.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug pkg-assert Change related to package testify/assert
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants