Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impr: CallerInfo should print full paths to the terminal #1201

Merged
merged 2 commits into from Jun 29, 2022
Merged

impr: CallerInfo should print full paths to the terminal #1201

merged 2 commits into from Jun 29, 2022

Commits on Jun 29, 2022

  1. impr: CallerInfo should print full paths to the terminal 

    I am proposing this simple change, which changes this output
```
--- FAIL: TestABC (0.00s)
    --- FAIL: TestABC/C (0.00s)
        /this/is/a/path/to/file_test.go:258:
            	Error Trace:	file_test.go:258
            	            				file_test.go:748
            	Error:      	Not equal:
...
```
to this:
```
--- FAIL: TestABC (0.00s)
    --- FAIL: TestABC/C (0.00s)
        /this/is/a/path/to/file_test.go:258:
            	Error Trace:	/this/is/a/path/to/file_test.go:258
            	            				/this/is/a/path/to/file_test.go:748
            	Error:      	Not equal:
...
```

With the latter output, it is much more straightforward to find the file
you are looking for, even though in the displayed case, the file is the same.

However, for VSCodium, the case is a little more helpful, since VSCodium's
terminal is smart enough to recognize the output, and make links out of that input.

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
    Stavros Ntentos committed Jun 29, 2022
    Copy the full SHA
    bad14dc View commit details
    Browse the repository at this point in the history

  2. test: fix the tests that depended on the previous behavior 

    Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
    Stavros Ntentos committed Jun 29, 2022
    Copy the full SHA
    d328605 View commit details
    Browse the repository at this point in the history