URLQuery with index slice keys #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added tests wrt #71 but I will write additional tests separately. |
|
@earncef Could give this a rebase? |
|
Done |
hanzei
requested changes
Jun 6, 2018
conversions.go
Outdated
| @@ -131,25 +148,42 @@ func (m Map) parseURLValues(queryMap Map, vals url.Values, key string) { | |||
| m.parseURLValues(New(v), vals, key+"["+k+"]") | |||
| } | |||
| case val.IsMSISlice(): | |||
There was a problem hiding this comment.
This case isn't covered by any testcases. Mind adding some? I think you can reuse the val.IsObjxMapSlice() ones
There was a problem hiding this comment.
Due to a previous pull request, this part is no longer necessary. Updated the code and added tests.
|
I agree. What would you consider the case for error though? Not being one of "" or "[]" or "[I]"? |
|
@hanzei any update on the last commit? |
Correct. I would limit |
|
Done |
hanzei
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain APIs (I believe those written in PHP) seem to be unable to parse correctly URLQuery() result containing slices generated by URLValuesSliceKeySuffix="" or URLValuesSliceKeySuffix="[]".
The solution is to pass the slices with an index so that they are read correctly.
For instance, in order to parse slices of the form correctly:
objx.Map{"mapSlice": []objx.Map{objx.Map{"age": 40, "sex": "male"}, objx.Map{"height": 152}}}
the query needs to be:
mapSlice[0][age]=40&mapSlice[0][sex]=male&mapSlice[1][height]=152
Currently these two forms are possible which don't work:
mapSlice[age]=40&mapSlice[sex]=male&mapSlice[height]=152
mapSlice[][age]=40&mapSlice[][sex]=male&mapSlice[][height]=152
I've modified the code to check for URLValuesSliceKeySuffix="[i]" and use slice indexes when present