fix: ignore the gitignored files in the scan to improve performance #3975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3047
This uses
globify-gitignore
to get the glob patterns of the gitignore file at the root and appends those to the ignore pattern of theglob
package. This significantly improves the performance ofcspell
as those directories are excluded in the scan.I see speeds up of 3x to 10x depending on the size of the project!
cspell
usesglob
instead offast-glob
, I had to make some changes in the output ofglobify-gitignore
. I will modify the API ofglobify-gitignore
a bit so that we don't have to do these changes here:feat: return an object to indicate inclusion + use relative globs aminya/globify-gitignore#1