Add Win32 API names dictionary #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason3S
reviewed
Oct 17, 2021
dictionaries/win32/src/generate.py
Outdated
| # Split around numbers | ||
| matches = flatten([re.split(r'[0-9]+', term) for term in matches]) | ||
|
|
||
| return [term.lower() for term in matches if len(term) > 3 and not term.isnumeric()] |
There was a problem hiding this comment.
It is better to keep the case. The spell checker is case sensitive.
There was a problem hiding this comment.
See #589 (comment) for a discussion.
|
Thanks for doing this. |
|
I think a Win32 dictionary is useful for other people as well. |
|
I realized the generator might be missing words that are used in |
LuizZak
changed the title
LuizZak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(in WIP while I investigate the generator not collecting enumerators behind typedefs correctly.)When working with Win32 APIs, a lot of the commonly used nomenclature and identifiers can be triggered by the spell checker, like
LPCWSTR,HRESULT,wcsnicmp,uuidof, etc., so I decided to tackle that with a ready-to-use, comprehensive dictionary that can be easily generated by code.I created a python generator that sweeps an installed Windows SDK and extracts publicly-available APIs and constants to generate a (quite hefty, actually) dictionary that I hope will be useful for people doing low-level Win32 development.
I'm unsure if this is fit for this repository or if I'm better off creating a separate repo myself, so I'm opening a PR to check if it's an ok addition.