New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Update licenses for several dictionaries to match license of their sources #2627
feat!: Update licenses for several dictionaries to match license of their sources #2627
Conversation
2d86238
to
6106350
Compare
It is going to take me a bit to read through these. A few notes: From Top 10 Questions About the Apache License | Mend:
|
41a46af
to
95c3d2f
Compare
95c3d2f
to
bd83e99
Compare
Would it help to separate each of these commits into its own PR? |
Thank you. I had gotten stuck on the CC license and hadn't gotten back to it. The other ones are clear. |
4cd0c1b
to
3552974
Compare
Have you reviewed the CC license now, or should I break that commit off into a separate PR so that the rest can be merged and that one can be reviewed later? |
If you pull out the CC license, I'll merge this PR. I have been busy and reviewing licenses takes (for me that is) a special kind of attention. |
3552974
to
f9a4999
Compare
f9a4999
to
f4ff8f3
Compare
This is done! The one other change I made is I noticed that for Hebrew dictionary, which is being updated to AGPLv3, while I had correctly used the text of AGPLv3, I had labeled it as AGPLv2 in the other two files for some reason. I fixed these to all consistently reference v3 |
Thank you! |
Update licenses for several dictionaries
Dictionaries: en-common-misspellings, fa_IR, he, lt_LT, ro_RO, uk_UA
Description
Related to #441
Made the following license changes:
en-common-misspellings
:MIT
->CC BY-SA 4.0
EDIT: Moved to separate branch
fa_IR
:MIT
->Apache 2.0
he
:MIT
->AGPLv2
lt_LT
:MIT
->BSD-3-clause
ro_RO
:LGPL
->GPL-3.0
uk_UA
:LGPL
->GPL-3.0
References
Checklist
Code of Conduct
fix:
- for minor changes like adding words or fixing spelling issues.feat:
- for a significant change like adding a whole new set of words to a dictionary.feat!:
- for breaking changes, like file format or licensing changes.chore:
- for changes that do not impact the content of dictionaries.