This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
apache/pulsar#11804 added the custom implementations of
equals
andhashCode
methods ofServiceCnx
, which made KoP's spotbugs check fail withModifications
This PR adds the overrided
equals
andhashCode
methods by calling base class' same name methods simply. On the other hand, since the newequals
andhashCode
methods are based onctx
field and they are called when removingProducer
fromTopic
, this PR also updates thectx
field ofInternalServerCnx
.