This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[Schema Registry] Force authorization when kafkaEnableMultiTenantMetadata is false #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #1807 +/- ##
============================================
+ Coverage 17.72% 17.74% +0.01%
- Complexity 751 752 +1
============================================
Files 195 195
Lines 14155 14156 +1
Branches 1322 1322
============================================
+ Hits 2509 2512 +3
+ Misses 11463 11462 -1
+ Partials 183 182 -1
|
Demogorgon314
previously approved these changes
Apr 23, 2023
|
@BewareMyPower Can you help resolve conflicts? |
|
Okay, I forgot this PR for some time. |
…data is false ### Motivation Currently when the schema registry and authorization are both enabled, the authorization is only performed when `kafkaEnableMultiTenantMetadata` is false. It's not reasonable because the role of the token must have the write permission to the schema registry topic. ### Modifications - In `performAuthorizationValidation`, do not chec `kafkaEnableMultiTenantMetadata`. - Add the `testSchemaWrongAuth` to verify that a wrong role cannot be used to create an Avro produce. - Separate the default namespace and the default schema namespace in `KafkaAuthorizationTestBase` so that the permission requirements will be clear.
BewareMyPower
force-pushed
the
bewaremypower/schema-authz-fix
branch
from
7abe952
to
fcde386
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently when the schema registry and authorization are both enabled, the authorization is only performed when
kafkaEnableMultiTenantMetadatais false. It's not reasonable because the role of the token must have the write permission to the schema registry topic.Modifications
performAuthorizationValidation, do not checkkafkaEnableMultiTenantMetadata.testSchemaWrongAuthto verify that a wrong role cannot be used to create an Avro produce.KafkaAuthorizationTestBaseso that the permission requirements will be clear.Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)