Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Commit

Permalink
Fix flaky testMutiBrokerUnloadReload by running it at first (#683)
Browse files Browse the repository at this point in the history
Fixes #678

This PR doesn't fix the test completely. It just does the trick to change the test name so that the test can ran as the first test. See #682 for tracking this issue.
  • Loading branch information
BewareMyPower committed Aug 30, 2021
1 parent f115ea0 commit 378f34d
Showing 1 changed file with 6 additions and 4 deletions.
Expand Up @@ -176,7 +176,7 @@ public void setup() throws Exception {
}


@AfterMethod(timeOut = 30000)
@AfterMethod(timeOut = 30000, alwaysRun = true)
@Override
public void cleanup() throws Exception {
log.info("--- Shutting down ---");
Expand Down Expand Up @@ -379,10 +379,12 @@ public void testMutiBrokerAndCoordinator() throws Exception {
}

// Unit test for unload / reload user topic bundle, verify it works well.
@Test(timeOut = 30000)
public void testMutiBrokerUnloadReload() throws Exception {
// NOTE: Currently the testMultiBrokerUnloadReload is flaky. If it ran after other tests, it would be easy to fail.
// So we just change the priority to make it run first to avoid CI failing at this test for this moment.
@Test(timeOut = 30000, priority = -1)
public void testMultiBrokerUnloadReload() throws Exception {
int partitionNumber = 10;
String kafkaTopicName = "kopMutiBrokerUnloadReload" + partitionNumber;
String kafkaTopicName = "kopMultiBrokerUnloadReload" + partitionNumber;
String pulsarTopicName = "persistent://public/default/" + kafkaTopicName;
String kopNamespace = "public/default";

Expand Down

0 comments on commit 378f34d

Please sign in to comment.