-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts/pulsar] adding flag webSocketServiceEnabled cm #653
base: master
Are you sure you want to change the base?
Conversation
@@ -42,7 +42,9 @@ data: | |||
numHttpServerThreads: "8" | |||
zooKeeperSessionTimeoutMillis: "30000" | |||
statusFilePath: "{{ template "pulsar.home" . }}/status" | |||
|
|||
{{- if .Values.proxy.websocket.enabled }} | |||
webSocketServiceEnnabled: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webSocketServiceEnnabled: "true" | |
webSocketServiceEnabled: "true" |
@fantapsody I think there is no need to enable ws on broker, https://github.com/streamnative/charts/blob/master/charts/pulsar/values.yaml#L1291 allows to enable websocket on proxy. |
@ericsyh what happens when we use istio and the proxy is disabled? |
@polyzos You mean the scenario that enabled Istio but wanna to use the websocket right? I think it's quite a good point, the proxy now has to been disabled cause there is a bug in the proxy that it cannot forward HTTP requests correctly when mTLS is on. If this problem is fixed, proxy can work with Istio. So for the websocket, if currently no specific request for using websocket with Istio enabled, i prefer waiting for the proxy bug fixing. |
Motivation
Modifications
The proxy-configmap.yaml and broker-configmap.yaml are modified to enable websocket services.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
[ x ]
no-need-doc
(Please explain why)