Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add langchain-community to test dependencies #8709

Merged
merged 13 commits into from
Jun 6, 2024

Conversation

LukasMasuch
Copy link
Collaborator

Describe your changes

The Streamlit integration functionality in langchain was moved to a dedicated module called langchain-community. This PR adds this to the test-dependencies.


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@LukasMasuch LukasMasuch changed the title Add langchain community to test dependencies Add langchain-community to test dependencies May 18, 2024
@LukasMasuch LukasMasuch added the dev:upgrade-dependencies Forces updating of the latest PyPi dependencies label May 21, 2024
@@ -65,9 +54,14 @@ def test_stable_api(self):
thought_labeler=LLMThoughtLabeler(),
)

@pytest.mark.skipif(
is_version_less_than(langchain.__version__, "0.2"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this check if we set the min version above this in the test dependencies here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point; the skip can be removed 👍

Copy link
Collaborator

@kmcgrady kmcgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I imagine the e2e tests just need to rebase.

@LukasMasuch LukasMasuch merged commit 0e6190d into develop Jun 6, 2024
37 checks passed
@LukasMasuch LukasMasuch deleted the fix/missing-langchain-test-dependency branch June 6, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants