-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add langchain-community to test dependencies #8709
Conversation
@@ -65,9 +54,14 @@ def test_stable_api(self): | |||
thought_labeler=LLMThoughtLabeler(), | |||
) | |||
|
|||
@pytest.mark.skipif( | |||
is_version_less_than(langchain.__version__, "0.2"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this check if we set the min version above this in the test dependencies here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point; the skip can be removed 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I imagine the e2e tests just need to rebase.
Describe your changes
The Streamlit integration functionality in langchain was moved to a dedicated module called
langchain-community
. This PR adds this to the test-dependencies.Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.