Migrate select slider to playwright #8703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasMasuch
approved these changes
May 21, 2024
|
|
||
| # Move mouse to 500, 0 pixels on the screen to simulate dragging left | ||
| app.mouse.move(500, 0) | ||
| app.mouse.up() |
There was a problem hiding this comment.
nit: This triggers a rerun or? maybe we add a wait_for_app_run(app) here as well to make this more obvious. The current setup should be pretty save regarding flakiness, but we had a couple of cases where adding this also improved flakiness
e2e_playwright/st_select_slider.py
Outdated
| def format_option(option): | ||
| return f"Color: {option}" | ||
|
|
||
|
|
||
| w1 = st.select_slider( | ||
| "Label 1", |
There was a problem hiding this comment.
nit: In many other widget tests we have been using the labels to give some indication of what the widgets is supposed to be tested for:
streamlit/e2e_playwright/st_text_input.py
Line 33 in 7f24fc0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.