Feature: st.logo
#8554
Merged
Feature: st.logo
#8554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayagbarnes
requested review from
vdonato,
LukasMasuch and
sfc-gh-mnowotka
as code owners
kmcgrady
reviewed
Apr 30, 2024
e2e_playwright/__snapshots__/linux/hello_app_test/hello_app-animation_demo_page[chromium].png
Outdated
Show resolved
Hide resolved
...dataframe_interactions_test/st_data_editor-selected_row_for_deletion[dark_theme-firefox].png
Outdated
Show resolved
Hide resolved
...st_dataframe_interactions_test/st_data_editor-row_deletion_toolbar[light_theme-chromium].png
Outdated
Show resolved
Hide resolved
e2e_playwright/__snapshots__/linux/st_graphviz_chart_test/st_graphviz-fullscreen[chromium].png
Outdated
Show resolved
Hide resolved
..._plotly_chart_test/st_plotly_chart-container_width_false_fullscreen[dark_theme-chromium].png
Outdated
Show resolved
Hide resolved
kmcgrady
approved these changes
Apr 30, 2024
LukasMasuch
approved these changes
May 2, 2024
There was a problem hiding this comment.
nit: A couple of the caption test snapshots are a bit cut off (probably overlayed by the header). But I think this might be solved once we update the caption tests to playwright.
sfc-gh-lmasuch
approved these changes
May 2, 2024
There was a problem hiding this comment.
nit: it might be a good idea to add a print-test where there is a logo (with sidebar opened and closed).
|
In general I think it'd be great if we put screenshots into the PR descriptions with a before/after comparison to allow for a quick visual overview for the reviewer of what exactly has changed in a PR |
sfc-gh-braethlein
approved these changes
May 2, 2024
raethlein
added a commit
that referenced
this pull request
May 10, 2024
## Describe your changes The app header bar height changed in #8554 and now the heading can be overlayed by it when clicking on the anchor. This PR fixes this by using the correct height. ## GitHub Issue Link (if applicable) ## Testing Plan - manual tests --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add a new command
st.logoto display a logo in the top left of main page & sidebarTesting Plan
Please note: this PR has SO MANY snapshot updates as a result of changing Streamlit's
headerHeight- this was a Design decision to ensure the header's toolbar buttons align with the logo image & the open/close sidebar buttons. Essentially every sidebar/full screen snapshot is impacted by these changes.