New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade vega lite and vega js versions #8505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overal, LGTM. But it might be good to also directly upgrade the other two vega dependencies. Also, the tests are broken :( so it might be a bit more work to get this update finished.
@@ -101,10 +101,10 @@ | |||
"typescript": "^4.9.5", | |||
"unist-util-visit": "^4.1.2", | |||
"uuid": "^9.0.0", | |||
"vega": "^5.23.0", | |||
"vega": "^5.28.0", | |||
"vega-embed": "^6.23.0", | |||
"vega-interpreter": "^1.0.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a patch upgrade for vega-interpreter
@@ -101,10 +101,10 @@ | |||
"typescript": "^4.9.5", | |||
"unist-util-visit": "^4.1.2", | |||
"uuid": "^9.0.0", | |||
"vega": "^5.23.0", | |||
"vega": "^5.28.0", | |||
"vega-embed": "^6.23.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a minor upgrade for vega-embed
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Superseded by #8605 |
Describe your changes
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.