Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade vega lite and vega js versions #8505

Closed
wants to merge 1 commit into from

Conversation

sfc-gh-wihuang
Copy link
Contributor

Describe your changes

  • title

GitHub Issue Link (if applicable)

Testing Plan

  • Explanation of why no additional tests are needed
  • Unit Tests (JS and/or Python)
  • E2E Tests
  • Any manual testing needed?

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

LukasMasuch
LukasMasuch previously approved these changes Apr 15, 2024
Copy link
Collaborator

@LukasMasuch LukasMasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overal, LGTM. But it might be good to also directly upgrade the other two vega dependencies. Also, the tests are broken :( so it might be a bit more work to get this update finished.

@@ -101,10 +101,10 @@
"typescript": "^4.9.5",
"unist-util-visit": "^4.1.2",
"uuid": "^9.0.0",
"vega": "^5.23.0",
"vega": "^5.28.0",
"vega-embed": "^6.23.0",
"vega-interpreter": "^1.0.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a patch upgrade for vega-interpreter

@@ -101,10 +101,10 @@
"typescript": "^4.9.5",
"unist-util-visit": "^4.1.2",
"uuid": "^9.0.0",
"vega": "^5.23.0",
"vega": "^5.28.0",
"vega-embed": "^6.23.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a minor upgrade for vega-embed

@LukasMasuch LukasMasuch dismissed their stale review April 15, 2024 22:11

Test seems to be broken

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 30, 2024
@vdonato
Copy link
Collaborator

vdonato commented May 6, 2024

Superseded by #8605

@vdonato vdonato closed this May 6, 2024
@vdonato vdonato deleted the upgrade/vegalite branch May 6, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants