[Fix CI tests] Failure on virtual env setup for pre-commit: Disable/Bump isort to 5.12.0 #6028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayagbarnes
changed the title
sfc-gh-tszerszen
suggested changes
Jan 30, 2023
There was a problem hiding this comment.
4 hours ago the fix was released in isort 5.11.5 version, let's not merge it and just upgrade to 5.11.5 instead, here is the PR: #6031
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtual Env setup for GHA CI broken due to PyCQA/isort#2077
Fixed by PyCQA/isort#2078 in isort 5.12.0, which also dropped support for Python 3.7
Temporarily disabling isort will unblock CI tests/PRs/Nightly until either a fix is available (track below) or we transition
PYTHON_MIN_VERSIONto 3.8...Issue asking for fix applicable for Python 3.7 here