New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix table overflow styling #4934
Conversation
a3fe9cc
to
17a2d7b
Compare
Do you know why the height in the table snapshots is influenced by this change? It is probably requiring some additional space for the scrollbars, or? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 馃憤 But I think we might be able to prevent the additional spacing:
I saw a recent task from @jrieke to have all top/bottom paddings standardized (including tables, charts, and data frames). We are probably fine to add this right now since it is not standardized yet, but maybe overlay
is a better way to do this since it won't add any extra space for the scrollbar (at least in webkit browsers). We are using this in a few places in the codebase, e.g.:
overflow: ["auto", "overlay"], |
My suggestion would be to change it to:
overflowX: ["auto", "overlay"]
overflowX
since we are mainly trying to fix the vertical dimension, or? If overlay
does not work, I'm also fine with auto
.
馃摎 Context
Currently,
st.table
content overlaps beyond the parent container - this PR fixes the issue by styling the overflow content to be scrolled for both arrow/legacy.What kind of change does this PR introduce?
馃 Description of Changes
overflow: "auto"
to the styled components forArrowTable
andTable
Revised:
Current:
馃И Testing Done
馃寪 References
Does this depend on other work, documents, or tickets?
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.