Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin higher version of protobuf in dev dependencies #4793

Merged
merged 2 commits into from
May 28, 2022

Conversation

LukasMasuch
Copy link
Collaborator

馃摎 Context

As mentioned in this in this PR #4779, Streamlit requires protobuf>=3.19 during development. At runtime, protobuf>=3.12 is fine.

馃 Description of Changes

  • Add protobuf>=3.19 to dev dependencies.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

Copy link
Contributor

@tconkling tconkling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - do you mind adding a comment above the new line in the Pipfile, to call out that we're deliberately targeting a higher version of protobuf for development builds than we are for release builds, because of the mypy-protobuf dev dep?

@LukasMasuch LukasMasuch merged commit ec9eb3a into develop May 28, 2022
@sfc-gh-kmcgrady sfc-gh-kmcgrady deleted the fix/protobuf-dev-dependency branch October 5, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants