Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations for image #4708

Merged
merged 3 commits into from May 10, 2022
Merged

Add type annotations for image #4708

merged 3 commits into from May 10, 2022

Conversation

harahu
Copy link
Contributor

@harahu harahu commented May 8, 2022

馃摎 Context

Continuing from where I left off in #4657

  • What kind of change does this PR introduce?

    • Other, please describe: Type Annotations

馃 Description of Changes

  • Add type annotations for the image module

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

vdonato
vdonato approved these changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@vdonato vdonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, but otherwise LGTM

lib/streamlit/elements/image.py Outdated Show resolved Hide resolved
@vdonato vdonato merged commit d7d0257 into streamlit:develop May 10, 2022
tconkling added a commit that referenced this pull request May 11, 2022
@tconkling
Merge branch 'develop' into prototype/snowflake
825405a 
* develop:
  Improve exception formatting with rich (#4294)
  Fix st.metric return value (#4716)
  Add type annotations for metric (#4705)
  Add type annotations for image (#4708)
@harahu harahu deleted the harahu/types/image branch May 12, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdonato vdonato vdonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harahu @vdonato