Import Final from typing or typing_extensions depending on the Python version #4692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willhuang1997
approved these changes
May 4, 2022
tconkling
added a commit
that referenced
this pull request
May 10, 2022
* develop: (21 commits) Remove branching imports and always import from typing_extensions (#4699) Add type annotations for media (#4706) Components adjustments (#4694) Type annotations for type_util (#4704) Add type annotations for utils (#4703) Argument types for iframe (#4707) Add type annotations for write (#4686) Add type annotations for doc_string (#4690) Add type annotations for progress (#4688) Add type annotations for exception (#4681) Add type annotations for plotly_chart (#4684) Wrap Markdown text when there's no word break (#4696) Add type annotations for __init__.py (#4687) Make typing-extensions and unconditional dependency (#4697) Add type annotations for balloons (#4679) Add type annotations for empty (#4680) Add type annotations for json (#4682) Add type annotations for layouts (#4683) Add type annotations for snow (#4685) Import Final from typing or typing_extensions depending on the Python version (#4692) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
I noticed that trying to run streamlit in a fresh wheel running on Python >= 3.8 explodes
since we conditionally install the
typing_extensionsmodule, and #4657 importsFinalfrom
typing_extensionsunconditionally. This PR fixes this.What kind of change does this PR introduce?
🧠 Description of Changes