Add type annotations for plotly_chart #4684
Conversation
| from typing import Final, Literal | ||
| else: | ||
| from typing_extensions import Final, Literal | ||
|
|
There was a problem hiding this comment.
@vdonato I changed the imports here to be python version dependent. In the process I discovered that my used of TypeAlias actually does require typing_extensions to be installed almost unconditionally.
I thought I'd mention it as input to your decision process regarding that dependency.
There was a problem hiding this comment.
Thanks yet again @harahu!
If we could bug you to make one more batch of changes to these PRs, I think that now that typing_extensions is always installed, we might as well remove the branching imports here (I'll make a quick PR removing them in the ~2 places where they already exist, so no need to worry about those).
You mentioned in a comment in another PR that having these branching imports even with typing_extensions always installed may be reasonable as it gives us a signal as to when the imports can be made from the main typing package, but I feel like this isn't worth the added complexity. I also feel like it'll most likely never be problematic if we entirely forget to change these imports to be from typings > typing_extensions as we drop support for older versions of Python (and if types get removed entirely from typing_extensions, we'll catch it in CI).
I'll go ahead and approve the currently open PRs and can merge them as these last changes are made.
| from typing import Final, Literal | ||
| else: | ||
| from typing_extensions import Final, Literal | ||
|
|
There was a problem hiding this comment.
Thanks yet again @harahu!
If we could bug you to make one more batch of changes to these PRs, I think that now that typing_extensions is always installed, we might as well remove the branching imports here (I'll make a quick PR removing them in the ~2 places where they already exist, so no need to worry about those).
You mentioned in a comment in another PR that having these branching imports even with typing_extensions always installed may be reasonable as it gives us a signal as to when the imports can be made from the main typing package, but I feel like this isn't worth the added complexity. I also feel like it'll most likely never be problematic if we entirely forget to change these imports to be from typings > typing_extensions as we drop support for older versions of Python (and if types get removed entirely from typing_extensions, we'll catch it in CI).
I'll go ahead and approve the currently open PRs and can merge them as these last changes are made.
* develop: (21 commits) Remove branching imports and always import from typing_extensions (#4699) Add type annotations for media (#4706) Components adjustments (#4694) Type annotations for type_util (#4704) Add type annotations for utils (#4703) Argument types for iframe (#4707) Add type annotations for write (#4686) Add type annotations for doc_string (#4690) Add type annotations for progress (#4688) Add type annotations for exception (#4681) Add type annotations for plotly_chart (#4684) Wrap Markdown text when there's no word break (#4696) Add type annotations for __init__.py (#4687) Make typing-extensions and unconditional dependency (#4697) Add type annotations for balloons (#4679) Add type annotations for empty (#4680) Add type annotations for json (#4682) Add type annotations for layouts (#4683) Add type annotations for snow (#4685) Import Final from typing or typing_extensions depending on the Python version (#4692) ...
馃摎 Context
Continuing from where I left off in #4657
What kind of change does this PR introduce?
馃 Description of Changes
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.