Finish Part 2 of the machine ID v3 work #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History
Part 2 of the machine ID v3 work was implemented in this PR
The PR changed our Python code so we now calculate
machine_id_v3Great! 馃槂
...but the PR did not touch the JS side!鈽癸笍
Meaning, we never send the new ID to Segment in any way.
See MetricsManager.ts and SessionInfo.ts. There are no mentions of
MachineIdV3in those.This PR
This PR finishes piping MachineIdV3 to Segment. So what we send to Segment is this:
machine_id_v1: this is the old MAC-address-based ID with annoying sudo step. This will go away in Part 3.machine_id_v2: this is the old random-number-based ID. This will go away in Part 3.machine_id_v3: the new MAC-address-based ID without sudo. This will go away in Part 3.user_id: the new MAC-address-based ID without sudoDouble-checking...
To make sure I was sending out the right things to Segment, I temporarily prepended "stidv1-", "stidv2-" and "stidv3-" to the three IDs and watched what MetricsManager.ts logged to the console:
Looks right!